Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: add OVHcloud #334

Merged
merged 1 commit into from
May 31, 2024
Merged

platform: add OVHcloud #334

merged 1 commit into from
May 31, 2024

Conversation

tormath1
Copy link
Collaborator

Everything is in the title.

Related to: flatcar/Flatcar#1453

@tormath1 tormath1 self-assigned this May 28, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-334.westeurope.1.azurestaticapps.net

@tormath1 tormath1 marked this pull request as ready for review May 28, 2024 14:56
@tormath1 tormath1 requested a review from a team May 28, 2024 14:56
krnowak
krnowak previously approved these changes May 28, 2024
Copy link
Contributor

@till till left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gut to me 😁

Kinda wild that OpenStack is the only true multi cloud environment where you can use the same tools across providers. 🫣

Copy link
Contributor

@sbraz sbraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this :) I'll ask some of my colleagues who work on the public cloud team to look into it as well.

@@ -30,6 +30,7 @@ platforms and bare metal servers.
* [Hetzner][hetzner]
* [OpenStack][openstack]
* [Brightbox][brightbox]
* [OVH Cloud][ovhcloud] (community support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit but

Suggested change
* [OVH Cloud][ovhcloud] (community support)
* [OVHcloud][ovhcloud] (community support)

(I'm only mentioning it once but there are other instances).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a nit: this is the kind of feedback I'm expecting when asking review from OVH folks :D

--property hw_qemu_guest_agent=yes \
--file flatcar_production_openstack_image.img \
flatcar-beta
$ IMAGE_ID=$(openstack image show flatcar-beta --format json | jq -r .id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have OpenStack on my PC here but can't we do this?

Suggested change
$ IMAGE_ID=$(openstack image show flatcar-beta --format json | jq -r .id)
$ IMAGE_ID=$(openstack image show flatcar-beta --format value --column id)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you could just pass these to openstack image create and skip the image show command which could behave weirdly (fail?) if two images are named flatcar-beta.


Example:
```shell
$ openstack server show "${INSTANCE_ID}" --format json | jq -r .addresses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use --format value as well here? I wonder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works. Thanks for tips.

Boot the machine with the CLI, referencing the image ID from the import step above, your [Ignition file from Butane][butane-configs], a flavor of your choice and a network of your choice:

```shell
$ INSTANCE_ID=$(openstack server create \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My colleagues mention the fact that SSH key authentication should be strongly recommended when creating the instance.
Also another case where the command could only return the ID with --format, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My colleagues mention the fact that SSH key authentication should be strongly recommended when creating the instance.

That's the case: the SSH public key is provided via Ignition configuration. I noticed that the public key defined in the OVH portal does not appear in the OpenStack environment.
That's why I mention this earlier in the instance creation from the portal:

You can also add the SSH key to be used in the creation form (it will be fetched and injected into Flatcar by the coreos-metadata-sshkeys@.service).

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-334.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-334.westeurope.1.azurestaticapps.net

@tormath1 tormath1 changed the title platform: add OVH Cloud platform: add OVHcloud May 30, 2024
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Co-authored-by: Louis Sautier <sautier.louis@gmail.com>
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-334.westeurope.1.azurestaticapps.net

@tormath1 tormath1 requested a review from krnowak May 31, 2024 10:15
@tormath1 tormath1 merged commit a6a7dbe into master May 31, 2024
2 checks passed
@tormath1 tormath1 deleted the tormath1/ovh branch May 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants